Re: [PATCH v3 3/9] iommu/arm-smmu: Implement ->probe_finalize()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v3 3/9] iommu/arm-smmu: Implement ->probe_finalize()
From: Will Deacon <will@xxxxxxxxxx>
Date: Tue, 15 Jun 2021 19:21:35 +0100
Cc: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>, Thierry Reding <thierry.reding@xxxxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, Jonathan Hunter <jonathanh@xxxxxxxxxx>, Nicolin Chen <nicolinc@xxxxxxxxxx>, "linux-tegra@xxxxxxxxxxxxxxx" <linux-tegra@xxxxxxxxxxxxxxx>, "iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx" <iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx>, "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
In-reply-to: <BY5PR12MB376468558EB3330D64758210B3309@BY5PR12MB3764.namprd12.prod.outlook.com>
References: <20210603164632.1000458-1-thierry.reding@gmail.com> <20210603164632.1000458-4-thierry.reding@gmail.com> <CGME20210615180133eucas1p2563c2a173eca1fb5a1c5ccf654c23778@eucas1p2.samsung.com> <46e65ade-49cb-5437-5863-1f11ccc2205e@samsung.com> <BY5PR12MB376468558EB3330D64758210B3309@BY5PR12MB3764.namprd12.prod.outlook.com>
User-agent: Mutt/1.10.1 (2018-07-13)

On Tue, Jun 15, 2021 at 06:12:13PM +0000, Krishna Reddy wrote:
> > if (smmu->impl->probe_finalize)
> 
> The above is the issue. It should be updated as below similar to other instances impl callbacks.
> if (smmu->impl && smmu->impl->probe_finalize)

I'll push a patch on top shortly...

Will

Follow-Ups:
- Re: [PATCH v3 3/9] iommu/arm-smmu: Implement ->probe_finalize()
  - From: Will Deacon

References:
- [PATCH v3 0/9] arm64: tegra: Prevent early SMMU faults
  - From: Thierry Reding
- [PATCH v3 3/9] iommu/arm-smmu: Implement ->probe_finalize()
  - From: Thierry Reding
- Re: [PATCH v3 3/9] iommu/arm-smmu: Implement ->probe_finalize()
  - From: Marek Szyprowski
- RE: [PATCH v3 3/9] iommu/arm-smmu: Implement ->probe_finalize()
  - From: Krishna Reddy

Prev by Date: RE: [PATCH v3 3/9] iommu/arm-smmu: Implement ->probe_finalize()
Next by Date: Re: [PATCH v7 13/15] drm/tegra: Implement job submission part of new UAPI
Previous by thread: RE: [PATCH v3 3/9] iommu/arm-smmu: Implement ->probe_finalize()
Next by thread: Re: [PATCH v3 3/9] iommu/arm-smmu: Implement ->probe_finalize()
Index(es):
- Date
- Thread

[Index of Archives] [ARM Kernel] [Linux ARM] [Linux ARM MSM] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]