On Mon, Apr 26, 2021 at 11:01:00AM +0200, Krzysztof Kozlowski wrote: > On 20/04/2021 18:52, Thierry Reding wrote: > > From: Thierry Reding <treding@xxxxxxxxxx> > > > > Tegra20 requires a slightly different interrupt handler than Tegra30 and > > later, so parameterize the handler, so that each SoC implementation can > > provide its own. > > > > While at it, also make IRQ support optional, which will help unify the > > Tegra186 memory controller driver with this one. > > Please split making it optional to separate patch. Looking at the code > should be possible and not affect bisectability. Technically that means I'd have to add a check for valid callback, otherwise it'd risks oopsing if for whatever reason that's passed in as NULL. It shouldn't be a problem in practice because it'll be valid in all cases, at least until the unification patch, so perhaps there's no need for the check if it's made optional in a subsequent patch anyway. Thierry
Attachment:
signature.asc
Description: PGP signature
