On Tue, Mar 23, 2021 at 06:00:34PM +0300, Dmitry Osipenko wrote: > 23.03.2021 17:43, Mikko Perttunen пишет: > >> > >> FWIW, I would've been fine with stashing all of this into drm.c as well > >> since the rest of the UAPI is in that already. The churn in this patch > >> is reasonably small, but it would've been even less if this was just all > >> in drm.c. > > > > I think we shouldn't have the uapi in drm.c -- it just makes the file a > > bit of a dumping ground. I think drm.c should have the code that relates > > to initialization and initial registration with DRM. > > +1 drm.c is already very unmanageable / difficult to follow, it > absolutely must be split up. I guess this comes down to personal preference. I don't find it difficult to navigate large files. On the contrary, I find it much more challenging to navigate a code base spread over lots and lots of files. I don't feel strongly about moving this code into a separate file, though, but let's maybe compromise and leave it at that. No need to split this out into 5 (or whatever it was) different tiny files that the end result of this series seems to yield. Thierry
Attachment:
signature.asc
Description: PGP signature
