On 02/03/2021 13:51, Dmitry Osipenko wrote:
> 02.03.2021 15:45, Daniel Lezcano пишет:
>> On 02/03/2021 10:54, Dmitry Osipenko wrote:
>>> The do_idle firmware call is unused by all Tegra SoCs, hence remove it in
>>> order to keep driver's code clean.
>>>
>>> Tested-by: Anton Bambura <jenneron@xxxxxxxxxxxxxx> # TF701 T114
>>> Tested-by: Matt Merhar <mattmerhar@xxxxxxxxxxxxxx> # Ouya T30
>>> Tested-by: Peter Geis <pgwipeout@xxxxxxxxx> # Ouya T30
>>> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
>>> ---
[ ... ]
>>> if (!IS_ENABLED(CONFIG_PM_SLEEP)) {
>>> - if (!tegra_cpuidle_using_firmware())
>>> - tegra_cpuidle_disable_state(TEGRA_C7);
>>
>> So firmware_ops->do_idle is always NULL, thus
>> tegra_cpuidle_using_firmware() is always false and
>> tegra_cpuidle_disable_state() always called, right ?
>
> Yes, the tegra_cpuidle_disable_state(TEGRA_C7) is always
> called if CONFIG_PM_SLEEP is disabled in kernel config.
Ok, thanks.
Reviewed-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
