On 02/03/2021 10:54, Dmitry Osipenko wrote:
> The do_idle firmware call is unused by all Tegra SoCs, hence remove it in
> order to keep driver's code clean.
>
> Tested-by: Anton Bambura <jenneron@xxxxxxxxxxxxxx> # TF701 T114
> Tested-by: Matt Merhar <mattmerhar@xxxxxxxxxxxxxx> # Ouya T30
> Tested-by: Peter Geis <pgwipeout@xxxxxxxxx> # Ouya T30
> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> ---
>
> Changelog:
>
> v2: - No changes. V1 got no attention, hence re-sending.
>
> drivers/cpuidle/cpuidle-tegra.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle-tegra.c b/drivers/cpuidle/cpuidle-tegra.c
> index 29c5e83500d3..508bd9f23792 100644
> --- a/drivers/cpuidle/cpuidle-tegra.c
> +++ b/drivers/cpuidle/cpuidle-tegra.c
> @@ -48,11 +48,6 @@ enum tegra_state {
> static atomic_t tegra_idle_barrier;
> static atomic_t tegra_abort_flag;
>
> -static inline bool tegra_cpuidle_using_firmware(void)
> -{
> - return firmware_ops->prepare_idle && firmware_ops->do_idle;
> -}
> -
> static void tegra_cpuidle_report_cpus_state(void)
> {
> unsigned long cpu, lcpu, csr;
> @@ -139,10 +134,6 @@ static int tegra_cpuidle_c7_enter(void)
> if (err && err != -ENOSYS)
> return err;
>
> - err = call_firmware_op(do_idle, 0);
> - if (err != -ENOSYS)
> - return err;
> -
> return cpu_suspend(0, tegra30_pm_secondary_cpu_suspend);
> }
>
> @@ -356,9 +347,7 @@ static int tegra_cpuidle_probe(struct platform_device *pdev)
> * is disabled.
> */
> if (!IS_ENABLED(CONFIG_PM_SLEEP)) {
> - if (!tegra_cpuidle_using_firmware())
> - tegra_cpuidle_disable_state(TEGRA_C7);
So firmware_ops->do_idle is always NULL, thus
tegra_cpuidle_using_firmware() is always false and
tegra_cpuidle_disable_state() always called, right ?
> + tegra_cpuidle_disable_state(TEGRA_C7);
> tegra_cpuidle_disable_state(TEGRA_CC6);
> }
>
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
