On Fri, Jul 17, 2020 at 10:13 PM Dmitry Osipenko <digetx@xxxxxxxxx> wrote: > 17.07.2020 22:24, Arnd Bergmann пишет: > > On Fri, Jul 17, 2020 at 6:13 PM Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > >> ARM: tegra: Default configuration changes for v5.9-rc1 > >> > >> Enables a few new configuration options that are useful on the new Nexus > >> 7 and Acer A500 devices, as well as the userspace CPU frequency governor > >> that's mainly used for testing. > > > > I've pulled all the other branches, but I'm a little bit wary about > > this one since > > Dmitry's patch enables a number of options that would increase the kernel > > size, and I see no indication that it has been reviewed by anyone else. > > > > I think the changes all make sense, but I would prefer to have a wider > > audience for that patch and get some Acks. If you like, you can send the > > tegra specific changes in a new pull request in the meantime, and then > > send the remaining additions to the usual suspects as an RFC, with > > Cc:soc@xxxxxxxxxx, so I can apply it later if everyone is happy enough > > with it. > > Hello, Arnd! > > But these are already the tegra specific changes. The patch changes > tegra_defconfig and not the multi_v7_defconfig. > > Could you please clarify from whom would you expect to get more Acks if > not from the tegra maintainers? > > In practice nobody uses upstream defconfig as-is, it's only used as > initial template. So I'm not sure why tegra-kernel size makes you to > worry. Could you please explain? It was a mistake on my end, for some reason I thought you were changing the arm64 defconfig, which does not have per-platform files. The patch is good, and I'll pull the branch as soon as I get to it (it's a bit late for today). Arnd