On 23-06-20, 10:49, Sumit Gupta wrote: > Hi Viresh, > > Thank you for the review. please find my reply inline. > > > > > +++ b/drivers/cpufreq/tegra194-cpufreq.c > > > @@ -0,0 +1,403 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved > > > > 2020 You missed this ? > T194 supports four CPU clusters, each with two cores. Each CPU cluster is > capable of running at a specific frequency sourced by respective NAFLL to > provide cluster specific clocks. Individual cores within a cluster write > freq in per core register. Cluster h/w forwards the max(core0, core1) > request to per cluster NAFLL. Okay, this is clear now. Add a comment about this max thing in the target routine to show why you need to do this on all CPUs. -- viresh
