17.04.2020 23:34, Laurent Pinchart пишет: > On Fri, Apr 17, 2020 at 11:11:06PM +0300, Dmitry Osipenko wrote: >> 17.04.2020 22:24, Laurent Pinchart пишет: >> ... >>> As I tried to explain before, if you wrap the panel in a bridge with >>> drm_panel_bridge_add() (or the devm_ variant), you will always have a >>> bridge associated with the output, and will be able to remove your >>> custom connector implementation. I thus recommend converting to >>> drm_panel_bridge_add() either as part of this patch series, or just >>> after it, to get full benefits. >>> >>> With the assumption that this will be handled, >>> >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> >> >> Thanks you very much! >> >> Yes, I got yours point about wrapping panel into the bridge. But I don't >> think that it's worth the effort right now because each Tegra output has >> it's own implantation of the connector and it should be cleaner not to >> touch that code. >> >> Secondly, I don't have hardware to test all available panel output types >> on Tegra and the benefits of messing with all that code are a bit dim to me. >> >> I can make a patch to wrap the RGB panel into a bridge, but this should >> make code a bit inconsistent in regards to not having a common code path >> for the "legacy" nvidia,panel. So perhaps it's better to leave it all >> as-is for now. > > I had a brief look at the code, converting the different output types > one by one would be a better way forward than not doing anything at all > in my opinion :-) Once you convert the first output it will also serve > as an example on how to do it, and hopefully other developers with > access to hardware could then do more conversions. > Thierry, would you want to have RGB panel converted into a bridge? If yes, I'll make a v5 with that change.
