On Fri, May 31, 2019 at 12:28:58PM +0200, Thierry Reding wrote: > On Fri, May 31, 2019 at 10:32:40AM +0100, Jon Hunter wrote: > > > > > > On 29/05/2019 11:26, Thierry Reding wrote: > > > From: Thierry Reding <treding@xxxxxxxxxx> > > > > > > For interrupts that are not wakeup sources but that may end up getting > > > mapped through the PMC as interrupt parent (this can happen for GPIOs), > > > return early in order to avoid a subsequent crash from an out-of-bounds > > > access to the register region. > > > > Maybe worth clarifying here what you mean by 'not wakeup sources' > > because the Tegra GPIO driver does have a set_wake() API to enable > > wakeup at the LIC IIRC. So maybe GPIOs that are not wakeup sources for > > what level of suspend? > > Wakeup sources in the context of PMC is always LP0 wakeup sources. At > that point I don't think LIC is enabled anymore. So LIC is to wake up > from LP1 (and perhaps LP2), while PMC wakeup sources need to be > configured in order to wake up from LP0. > > Adding Peter to confirm, I think he's more familiar with the power > states on earlier chips than I am. Yes. LIC is in a domain which is off during SC7 so it can't trigger a wakeup. Peter.