On 29/05/2019 11:26, Thierry Reding wrote: > From: Thierry Reding <treding@xxxxxxxxxx> > > For interrupts that are not wakeup sources but that may end up getting > mapped through the PMC as interrupt parent (this can happen for GPIOs), > return early in order to avoid a subsequent crash from an out-of-bounds > access to the register region. Maybe worth clarifying here what you mean by 'not wakeup sources' because the Tegra GPIO driver does have a set_wake() API to enable wakeup at the LIC IIRC. So maybe GPIOs that are not wakeup sources for what level of suspend? > Reported-by: Bitan Biswas <bbiswas@xxxxxxxxxx> > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> > --- > drivers/soc/tegra/pmc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c > index 653fe2c466f6..6e66b5e293be 100644 > --- a/drivers/soc/tegra/pmc.c > +++ b/drivers/soc/tegra/pmc.c > @@ -1924,6 +1924,9 @@ static int tegra_pmc_irq_set_wake(struct irq_data *data, unsigned int on) > unsigned int offset, bit; > u32 value; > > + if (WARN_ON(data->hwirq == ULONG_MAX)) > + return 0; > + > offset = data->hwirq / 32; > bit = data->hwirq % 32; Otherwise ... Acked-by: Jon Hunter <jonathanh@xxxxxxxxxx> Cheers Jon -- nvpublic
