-------- Weitergeleitete Nachricht --------
Betreff: Re: Patch: PCI: tegra: Use generic accessors where possible
Datum: Wed, 8 May 2019 07:40:51 +0200
Von: Bernd Kubu <bernd@xxxxxxx>
An: Thierry Reding <treding@xxxxxxxxxx>
Kopie (CC): Marcel Ziswiler <marcel.ziswiler@xxxxxxxxxxx>,
linux-tegra@xxxxxxxxxxxxxxx
Hi Thierry,
I try to be a bit more specific with this mail:
My hardware is a "Toradex Apalis TK1 2GB V1.1A".
I work on the current Ubuntu Bionic-Kernel (18.04) [1], which is a 4.15
kernel.
As you already mentioned, the patch [2] was added in 4.15. The
Toradex-patchset [3] was originally for 4.14. I applied this patchset
[3] to the bionic-kernel. A minor modification was necessary to get it
to work [4]. (I am currently testing with the other toradex-peripherals)
With this setup, the igb-driver for the onboard Intel ethernet network
controller [8086:157b] does not initialize correctly. I get the
following messages in dmesg:
[ 4.913881] pci 0000:01:00.0: [8086:157b] type 10 class 0x020000
[ 4.913913] pci 0000:01:00.0: unknown header type 10, ignoring device
It seems, the reading of the pci-header-type is not correct. It reads
"0x10" instead of "0x00" reproduceable. After comparing the kernel
changes between 4.14 and 4.15, I found the changes of patch [2] and
removed it for a test. Without this patch, the igb-driver initialized
correctly and the network controller worked. So, I assume, there is
still an issue with other than "pci_generic_config_read32" access.
So, I want to say, that if I use pci_generic_config_{read,write}32() for
all accesses, the network controller works for me. And it doesn't work,
if I use the tegra_pcie_config_{read,write}() functions for accesses.
I didn´t try it with a recent kernel. I assume, more modifications of
the Toradex-patchset are necessary to get it to work. If you intend to
track this issue for the recent kernel, I could give it a try..
Bernd
[1] git://kernel.ubuntu.com/ubuntu/ubuntu-bionic.git
[2] https://patchwork.kernel.org/patch/9967399/
[3]
http://git.toradex.com/cgit/meta-toradex-tegra.git/tree/recipes-kernel/linux/linux-toradex-mainline-4.14?h=rocko)
[4] patch1 below
--- patch1 ---
diff --git a/drivers/iio/adc/apalis-tk1-k20_adc.c
b/drivers/iio/adc/apalis-tk1-k20_adc.c
index b45e51df5c81..8a9d90b2f77d 100644
--- a/drivers/iio/adc/apalis-tk1-k20_adc.c
+++ b/drivers/iio/adc/apalis-tk1-k20_adc.c
@@ -87,7 +87,7 @@ static int apalis_tk1_k20_adc_read_raw(struct iio_dev
*indio_dev,
static const struct iio_info apalis_tk1_k20_adc_info = {
.read_raw = &apalis_tk1_k20_adc_read_raw,
- .driver_module = THIS_MODULE,
};
--- patch1 ---
Am 07.05.2019 um 21:39 schrieb Thierry Reding:
On Tue, May 07, 2019 at 04:03:37PM +0200, Bernd Kubu wrote:
Hello Thierry,
I have troubles with this patch:https://patchwork.kernel.org/patch/9967399/
My Intel Ethernet Network Controller (igb [8086:157b]) on the "Toradex Apalis
TK1 2GB V1.1A" does not work with the current Ubuntu Bionic Kernel (with
patches fromhttp://git.toradex.com/cgit/meta-toradex-tegra.git/tree/
recipes-kernel/linux/linux-toradex-mainline-4.14?h=rocko).
Looks like the baseline for that is 4.14. The patch that you referenced
above was applied to 4.15 and is not part of that Toradex patchset
either, so...
I get the following messages in dmesg:
[ 4.913881] pci 0000:01:00.0: [8086:157b] type 10 class 0x020000
[ 4.913913] pci 0000:01:00.0: unknown header type 10, ignoring device
After removing the changes from the patchhttps://patchwork.kernel.org/patch/
9967399/
---------
+}
+
static struct pci_ops tegra_pcie_ops = {
.add_bus = tegra_pcie_add_bus,
.remove_bus = tegra_pcie_remove_bus,
.map_bus = tegra_pcie_map_bus,
- .read = pci_generic_config_read32,
- .write = pci_generic_config_write32,
+ .read = tegra_pcie_config_read,
+ .write = tegra_pcie_config_write,
};
------
the Network Controller work.
So it seems this model has issues with other than 32-bit access.
... I'm not sure how that would be related here. Unless I'm misunder-
standing what you're saying. You are saying that if you use
pci_generic_config_{read,write}32() for all accesses, that the network
controller works for you? And it doesn't work if you use the
tegra_pcie_config_{read,write}() functions for accesses?
I'd be somewhat surprised if this wasn't working. I'm not aware of any
similar reports against the upstream kernel. Have you tried building a
recent linux-next, or -rc or something like the latest release (5.1)?
Adding Marcel here, perhaps he's encountered a similar issue. Also
adding the linux-tegra mailing list for broader visibility.
Thierry
Best regards,
Bernd
--
Bernd Kubu - IT Services
Heufeldstrasse 24
A-2640 Gloggnitz
Tel.: +43-699-13002768
E-Mail:mailto:bernd@xxxxxxx
