Re: Patch: PCI: tegra: Use generic accessors where possible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 07, 2019 at 04:03:37PM +0200, Bernd Kubu wrote:
> Hello Thierry,
> 
> I have troubles with this patch: https://patchwork.kernel.org/patch/9967399/
> 
> My Intel Ethernet Network Controller (igb [8086:157b]) on the "Toradex Apalis
> TK1 2GB V1.1A" does not work with the current Ubuntu Bionic Kernel (with
> patches from http://git.toradex.com/cgit/meta-toradex-tegra.git/tree/
> recipes-kernel/linux/linux-toradex-mainline-4.14?h=rocko).

Looks like the baseline for that is 4.14. The patch that you referenced
above was applied to 4.15 and is not part of that Toradex patchset
either, so...

> I get the following messages in dmesg:
> [    4.913881] pci 0000:01:00.0: [8086:157b] type 10 class 0x020000
> [    4.913913] pci 0000:01:00.0: unknown header type 10, ignoring device
> 
> After removing the changes from the patch https://patchwork.kernel.org/patch/
> 9967399/
> ---------
> 
> > +}
> > +
> >  static struct pci_ops tegra_pcie_ops = {
> >         .add_bus = tegra_pcie_add_bus,
> >         .remove_bus = tegra_pcie_remove_bus,
> >         .map_bus = tegra_pcie_map_bus,
> > -       .read = pci_generic_config_read32,
> > -       .write = pci_generic_config_write32,
> > +       .read = tegra_pcie_config_read,
> > +       .write = tegra_pcie_config_write,
> >  };
> >
> 
> ------
> 
> the Network Controller work.
> So it seems this model has issues with other than 32-bit access.

... I'm not sure how that would be related here. Unless I'm misunder-
standing what you're saying. You are saying that if you use
pci_generic_config_{read,write}32() for all accesses, that the network
controller works for you? And it doesn't work if you use the
tegra_pcie_config_{read,write}() functions for accesses?

I'd be somewhat surprised if this wasn't working. I'm not aware of any
similar reports against the upstream kernel. Have you tried building a
recent linux-next, or -rc or something like the latest release (5.1)?

Adding Marcel here, perhaps he's encountered a similar issue. Also
adding the linux-tegra mailing list for broader visibility.

Thierry

> 
> Best regards,
> 
>     Bernd
> 
> --
> Bernd Kubu - IT Services
> 
> Heufeldstrasse 24
> A-2640 Gloggnitz
> 
> Tel.: +43-699-13002768
> E-Mail: mailto:bernd@xxxxxxx
> 

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux