On 18/02/2019 08:42, Thierry Reding wrote: > On Sat, Feb 16, 2019 at 08:33:07AM -0800, Sowjanya Komatineni wrote: >> Tegra186 does not support multi-master mode and also there is no >> master fifo control register. >> >> This patch fixes supported features of Tegra186 and prevents >> crashing during boot as master fifo control register are not >> present on Tegra186 and prior. >> >> Signed-off-by: Sowjanya Komatineni <skomatineni@xxxxxxxxxx> >> --- >> drivers/i2c/busses/i2c-tegra.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > We really should've caught this earlier. Jon, let's think about ways to > make it easier to catch these things in the future on our test system. Indeed. This has fixed the boot regression I was seeing over the weekend on -next for Tegra186. However, I am bit confused here, because when I look at the Tegra186 TRM it states that the I2C supports multi-master mode which disagrees with this patch. Furthermore, it seems odd that Tegra210 and Tegra194 would support multi-master mode but Tegra186 does not. So is this really correct? Cheers Jon -- nvpublic
