Hi Chanwoo, On Thu, Feb 14, 2019 at 11:32:40PM +0900, Chanwoo Choi wrote: > Hi Matthias, > > When I contributed the something to devfreq.c, if the newly added functions > are internal/static, just added the function without 'devfreq_' prefix > in order to distinguish them from the exported function as following: > - find_available_min_freq() > - find_available_max_freq() > - set_freq_table() > > So, the governor_start/stop are the static function used only in devfreq.c, > in order to sustain the consistency of function naming, I recommened > that changes them as following: > - devfreq_governor_start -> governor_start > - devfreq_governor_stop -> governor_stop Sounds good, I'll update this in the next version. Thanks Matthias