On Thu, Feb 14, 2019 at 11:12:55PM +0900, Chanwoo Choi wrote: > Hi Matthias, > > Looks good to me for making the function to remove the duplicate code. > But, When I just tested the kernel build, following warnings occur > about devfreq_governor_stop(). > > In file included from ./include/linux/devfreq.h:16:0, > from drivers/devfreq/devfreq.c:23: > drivers/devfreq/devfreq.c: In function ‘devfreq_governor_stop’: > drivers/devfreq/devfreq.c:619:17: warning: format ‘%s’ expects > argument of type ‘char *’, but argument 4 has type ‘int’ [-Wformat=] > dev_warn(dev, "%s: Governor %s not stopped: %d\n", > ^ > ./include/linux/device.h:1380:22: note: in definition of macro ‘dev_fmt’ > #define dev_fmt(fmt) fmt > ^ > drivers/devfreq/devfreq.c:619:3: note: in expansion of macro ‘dev_warn’ > dev_warn(dev, "%s: Governor %s not stopped: %d\n", > ^ > drivers/devfreq/devfreq.c:619:17: warning: format ‘%d’ expects a > matching ‘int’ argument [-Wformat=] > dev_warn(dev, "%s: Governor %s not stopped: %d\n", > ^ > ./include/linux/device.h:1380:22: note: in definition of macro ‘dev_fmt’ > #define dev_fmt(fmt) fmt > ^ > drivers/devfreq/devfreq.c:619:3: note: in expansion of macro ‘dev_warn’ > dev_warn(dev, "%s: Governor %s not stopped: %d\n", For some reason the warnings don't pop up in my 4.19 build and I missed them when compile testing upstream :( I'll fix the format string in the next version. Thanks for the review and build test! Matthias
