[...]
> if (tegra_host->pad_calib_required)
> @@ -805,8 +854,15 @@ static int tegra_sdhci_init_pinctrl_info(struct device *dev,
> return -1;
> }
>
> - tegra_host->pinctrl_state_3v3 =
> - pinctrl_lookup_state(tegra_host->pinctrl_sdmmc, "sdmmc-3v3");
> + tegra_host->pinctrl_state_1v8_drv = pinctrl_lookup_state(
> + tegra_host->pinctrl_sdmmc, "sdmmc-1v8-drv");
This requires and updated DT doc for tegra sdhci. Please make that a
separate patch and put it first in the series. Also don't forget to
include the DT maintainers in the to field for that patch.
> +
> + tegra_host->pinctrl_state_3v3_drv = pinctrl_lookup_state(
> + tegra_host->pinctrl_sdmmc, "sdmmc-3v3-drv");
Ditto.
> +
> + tegra_host->pinctrl_state_3v3 = pinctrl_lookup_state(
> + tegra_host->pinctrl_sdmmc, "sdmmc-3v3");
> +
The above looks like an unnecessary line change. Please just stick to
the existing format and avoid changing code that doesn't need to be
changed.
> if (IS_ERR(tegra_host->pinctrl_state_3v3)) {
> dev_warn(dev, "Missing 3.3V pad state, err: %ld\n",
> PTR_ERR(tegra_host->pinctrl_state_3v3));
> --
> 2.7.4
>
Kind regards
Uffe
