On Mon, Sep 25, 2017 at 3:38 AM, Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > On Sun, Sep 24, 2017 at 10:13:57PM +0530, Harsha Sharma wrote: >> Replace all occurences of dev_info/err/dbg with DRM_DEV_INFO/ >> ERROR/DEBUG as we have DRM_DEV_* variants of drm print macros >> Done using following coccinelle semantic patch >> >> @r@ >> @@ >> >> ( >> -dev_info >> +DRM_DEV_INFO >> | >> -dev_err >> +DRM_DEV_ERROR >> | >> -dev_dbg >> +DRM_DEV_DEBUG >> ) >> >> Signed-off-by: Harsha Sharma <harshasharmaiitr@xxxxxxxxx> >> --- >> Changes in v2: >> -Break line over 80 characters >> -Changes in comments not required > > Please don't do this. Most of the functions that you're trying to > replace here are not DRM_DEV_*() for a very specific reason: none of > them have anything to do with DRM/KMS in particular. This is important, > in my opinion, because these messages are very device-specific and the > additional information added by the DRM format string aren't useful in > the context. Hey Thierry, It's likely not useful to a tegra expert such as yourself. However, when I'm switching between platforms or providing log-parsing instructions, it's very useful to say "grep for drm". Without the common drm prefix, the reader needs to know they're looking for tegra-sor, tegra-dc, etc as well. Not a big deal, I just wanted to provide color for why someone might want this. > > Perhaps the only ones I consider to be good candidates for this > conversion are the ones in drivers/gpu/drm/tegra/fb.c because they deal > with the DRM fbdev setup and hence are not device specific. And even in > those cases I'm not sure we gain very much by this conversion, > especially since most of the replacements now end up having to split up > argument lists. > > Sorry if this isn't documented anywhere. I also suspect other driver > maintainers will be less picky about this sort of thing, so you might > have more luck there. I think the TODO entry states that contributors should check with the driver maintainers before taking on this work, so it is documented :) Sean > > Thierry > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxx. > To post to this group, send email to outreachy-kernel@xxxxxxxxxxxxxxxx. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170925073841.GA12494%40ulmo.fritz.box. > For more options, visit https://groups.google.com/d/optout. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
