On Sun, Sep 24, 2017 at 10:13:57PM +0530, Harsha Sharma wrote: > Replace all occurences of dev_info/err/dbg with DRM_DEV_INFO/ > ERROR/DEBUG as we have DRM_DEV_* variants of drm print macros > Done using following coccinelle semantic patch > > @r@ > @@ > > ( > -dev_info > +DRM_DEV_INFO > | > -dev_err > +DRM_DEV_ERROR > | > -dev_dbg > +DRM_DEV_DEBUG > ) > > Signed-off-by: Harsha Sharma <harshasharmaiitr@xxxxxxxxx> > --- > Changes in v2: > -Break line over 80 characters > -Changes in comments not required Please don't do this. Most of the functions that you're trying to replace here are not DRM_DEV_*() for a very specific reason: none of them have anything to do with DRM/KMS in particular. This is important, in my opinion, because these messages are very device-specific and the additional information added by the DRM format string aren't useful in the context. Perhaps the only ones I consider to be good candidates for this conversion are the ones in drivers/gpu/drm/tegra/fb.c because they deal with the DRM fbdev setup and hence are not device specific. And even in those cases I'm not sure we gain very much by this conversion, especially since most of the replacements now end up having to split up argument lists. Sorry if this isn't documented anywhere. I also suspect other driver maintainers will be less picky about this sort of thing, so you might have more luck there. Thierry
Attachment:
signature.asc
Description: PGP signature
