Hi Thierry,
On Fri, Apr 08, 2016 at 06:13:13PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@xxxxxxxxxx>
>
> Changes to the pad controller device tree binding
Is there a commit we can reference for this pad controller binding
change? If so, I can fold it in.
Is there a benefit to keeping this binding patch separate from the
corresponding driver patch? It seems like it'd nice to have a
connection between them. (Sorry, I'm sure I've asked this before,
but I can't remember the answer.)
Trivial typos below that I've already fixed, but you can fold them in
if there's any reason to repost this.
> have required that
> each lane be associated with a separate PHY. Update the PCI host bridge
> device tree binding to allow each root port to define the list of PHYs
> required to drive the lanes associated with it.
>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
> ---
> Changes in v4:
> - add additional lanes subnode when dereferencing PHYs from the XUSB pad
> controller to reflect changes in its binding
>
> .../devicetree/bindings/pci/nvidia,tegra20-pcie.txt | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt b/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt
> index 75321ae23c08..f5364084b494 100644
> --- a/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt
> @@ -60,11 +60,14 @@ Required properties:
> - afi
> - pcie_x
>
> -Required properties on Tegra124 and later:
> +Required properties on Tegra124 and later (deprecated):
> - phys: Must contain an entry for each entry in phy-names.
> - phy-names: Must include the following entries:
> - pcie
>
> +These properties are deprecated in favour of per-lane PHYs define in each of
s/define/defined/
> +the root ports (see below).
> +
> Power supplies for Tegra20:
> - avdd-pex-supply: Power supply for analog PCIe logic. Must supply 1.05 V.
> - vdd-pex-supply: Power supply for digital PCIe I/O. Must supply 1.05 V.
> @@ -122,6 +125,13 @@ Required properties:
> - Root port 0 uses 4 lanes, root port 1 is unused.
> - Both root ports use 2 lanes.
>
> +Required properties for Tegra124 and later:
> +- phys: Must contain an phandle to a PHY for each entry in phy-names.
s/an phandle/a phandle/
> +- phy-names: Must include an entry for each active lane. Note that the number
> + of entries does not have to (though usually will) be equal to the specified
> + number of lanes in the nvidia,num-lanes property. Entries are of the form
> + "pcie-N": where N ranges from 0 to the value specified in nvidia,num-lanes.
> +
> Example:
>
> SoC DTSI:
> @@ -169,6 +179,9 @@ SoC DTSI:
> ranges;
>
> nvidia,num-lanes = <2>;
> +
> + phys = <&{/padctl@0,7009f000/pads/pcie/lanes/pcie-4}>;
> + phy-names = "pcie-0";
> };
>
> pci@2,0 {
> @@ -183,6 +196,9 @@ SoC DTSI:
> ranges;
>
> nvidia,num-lanes = <2>;
> +
> + phys = <&{/padctl@0,7009f000/pads/pcie/lanes/pcie-2}>;
> + phy-names = "pcie-0";
> };
> };
>
> --
> 2.8.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
