Re: [cbootimage PATCH 1/3] Fix the error reporting of get_bct_size_from_image()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/05/2015 09:03 AM, Alban Bedel wrote:
get_bct_size_from_image() should return negative error codes, so add
the missing minus signs. Also fix the return value check on
get_bct_size_from_image(), a negative value indicate an error not zero.

diff --git a/src/data_layout.c b/src/data_layout.c

@@ -1050,11 +1050,11 @@ int get_bct_size_from_image(build_image_context *context)

  	fp = fopen(context->input_image_filename, "r");
  	if (!fp)
-		return ENODATA;
+		return -ENODATA;

I see the exact same bug in read_bct_file() in the same source file. Since that's the same logical bug, any chance you could fix that too in the same patch?
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux