On 16 January 2015 at 19:06, Andrew Bresticker <abrestic@xxxxxxxxxxxx> wrote:
> On Fri, Jan 16, 2015 at 8:00 AM, Tomeu Vizoso <tomeu@xxxxxxxxxxxxxxx> wrote:
>> On 15 January 2015 at 19:35, Andrew Bresticker <abrestic@xxxxxxxxxxxx> wrote:
>>> Hi Tomeu,
>>>
>>> On Thu, Jan 15, 2015 at 9:11 AM, Tomeu Vizoso <tomeu@xxxxxxxxxxxxxxx> wrote:
>>>> I have seen that coreboot configures these ones differently:
>>>>
>>>> - ('sdmmc3_clk_pa6', 'sdmmc3', None, 'none',
>>>> False, False, False, False),
>>>> + ('sdmmc3_clk_pa6', 'sdmmc3', None, 'none',
>>>> False, True, False, False),
>>>> - ('sdmmc3_clk_lb_out_pee4', 'sdmmc3', None, 'none',
>>>> False, False, False, False),
>>>> + ('sdmmc3_clk_lb_out_pee4', 'sdmmc3', None, 'down',
>>>> False, True, False, False),
>>>> - ('sdmmc4_cmd_pt7', 'sdmmc4', None, 'none',
>>>> False, True, False, False),
>>>> + ('sdmmc4_cmd_pt7', 'sdmmc4', None, 'up',
>>>> False, True, False, False),
>>>> - ('dp_hpd_pff0', 'dp', None, 'up',
>>>> False, True, False, False),
>>>> + ('dp_hpd_pff0', 'dp', None, 'none',
>>>> False, True, False, False),
>>>>
>>>> May be good to have them match?
>>>
>>> I believe these should all be the same between Norrin (Nyan), Big, and
>>> Blaze, so I'd go with whatever is in the Norrin pinmux config (which I
>>> believe is what Simon's patch is based on).
>>
>> Even dp_hpd? In my testing I need to have pullup on big and with no
>> pull on blaze for the panel to work. I'm very weak in reading
>> schematics, but I see what I think is a pullup resistor in Big, and
>> none in Blaze.
>
> Maybe I'm missing something, but I don't see any difference between
> Big and Blaze with respect to dp_hpd. Coreboot also configures them
> both with no pull. I'll have to look into this more...
Sorry, I think I got confused somewhere there. In my most recent
testing, I need dp_hpd to be configured with no pull on big or I get
spurious interrupts. That caused problems only sometimes as it only
manifested in a race within the drm subsystem.
Simon, do you mind if I resend your patch to tegra-pinmux-scripts with
that pin fixed?
Thanks,
Tomeu
>> So in summary, I think that we should make this change to the pinmux
>> definition that Simon sent:
>>
>> - ('usb_vbus_en0_pn4', 'usb', None, 'none',
>> False, True, True, False),
>> - ('usb_vbus_en1_pn5', 'usb', None, 'none',
>> False, True, True, False),
>> + ('usb_vbus_en0_pn4', 'usb', None, 'up',
>> False, True, False, False),
>> + ('usb_vbus_en1_pn5', 'usb', None, 'up',
>> False, True, False, False),
>
> Yes. It ends up not mattering what the pull is when using a mainline
> DTS since they use a fixed regulator to drive these pins high, but
> you're right, the most correct thing for VBUS is input enabled with
> pull-up.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
