Re: [PATCH v2] Add support for Nyan-big

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tomeu,

On Thu, Jan 15, 2015 at 9:11 AM, Tomeu Vizoso <tomeu@xxxxxxxxxxxxxxx> wrote:
> I have seen that coreboot configures these ones differently:
>
> -    ('sdmmc3_clk_pa6',         'sdmmc3',      None,      'none',
> False, False, False, False),
> +    ('sdmmc3_clk_pa6',         'sdmmc3',      None,      'none',
> False, True,  False, False),
> -    ('sdmmc3_clk_lb_out_pee4', 'sdmmc3',      None,      'none',
> False, False, False, False),
> +    ('sdmmc3_clk_lb_out_pee4', 'sdmmc3',      None,      'down',
> False, True,  False, False),
> -    ('sdmmc4_cmd_pt7',         'sdmmc4',      None,      'none',
> False, True,  False, False),
> +    ('sdmmc4_cmd_pt7',         'sdmmc4',      None,      'up',
> False, True,  False, False),
> -    ('dp_hpd_pff0',            'dp',          None,      'up',
> False, True,  False, False),
> +    ('dp_hpd_pff0',            'dp',          None,      'none',
> False, True,  False, False),
>
> May be good to have them match?

I believe these should all be the same between Norrin (Nyan), Big, and
Blaze, so I'd go with whatever is in the Norrin pinmux config (which I
believe is what Simon's patch is based on).

> Besides, I have collected these differences between blaze and big,
> could you check with what you know?

These are the differences you've collected between blaze and big from
the schematic or... ?

> -    ('usb_vbus_en2_pff1',      'rsvd2',       None,      'down',
> True,  False, False, False),
> +    ('usb_vbus_en2_pff1',      'usb',         None,      'up',
> False, True,  False, False),

usb_vbus_en2 is not connected on all Nyan-based boards, so I would
just use whatever the Norrin config uses.

> -    ('usb_vbus_en0_pn4',       'usb',         None,      'none',
> False, True,  True,  False),
> -    ('usb_vbus_en1_pn5',       'usb',         None,      'none',
> False, True,  True,  False),
> +    ('usb_vbus_en0_pn4',       'usb',         None,      'up',
> False, True,  False, False),
> +    ('usb_vbus_en1_pn5',       'usb',         None,      'up',
> False, True,  False, False),

I would expect these to be like Venice2/Norrin: input enabled,
open-drain, no pull.

Thanks,
Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux