On Thu, Sep 18, 2014 at 08:59:53PM +0200, Sean Paul wrote: > On Thu, Sep 18, 2014 at 7:26 AM, Peter De Schrijver > <pdeschrijver@xxxxxxxxxx> wrote: > > On Wed, Sep 10, 2014 at 06:17:44PM +0200, Stephen Warren wrote: > >> On 09/10/2014 08:52 AM, Sean Paul wrote: > >> > This patch moves the mipi-cal gate registration down into the SoC > >> > specific files to reflect the different in parent between them. > >> > > >> > Without this change, MIPI calibration will fail on K1 devices if > >> > the 72MHz clock is off. > >> > >> This isn't a problem with this patch per se, but I notice that what's > >> removed from clk-tegra-periph.c is data in a table, whereas open-coded > >> calls are added to clk-tegra*.c. It'd be nice if the open-coded calls in > >> clk-tegra*.c could be converted to a table (simply with SoC-specific > >> data) and processed by the same function. Peter, would that make sense? > > > > Maybe yes. I will look into this. For this patch, it would make more sense > > to keep the entry in clk-tegra-periph.c as it can be used by both Tegra124 > > and Tegra132. > > > > How do you suggest we switch the parent based on 124 vs 132 if it > remains in clk-tegra-periph.c? > I would change the parent of mipi-cal in clk-tegra-periph.c to clk72mhz and use a different mechanism for Tegra114. Cheers, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
