Re: [PATCH v3 1/2] pinctrl: tegra: Add MIPI pad control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/18/2014 12:56 PM, Sean Paul wrote:
On Wed, Sep 10, 2014 at 12:08 PM, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote:
On 09/09/2014 01:58 PM, Sean Paul wrote:

This patch adds MIPI CSI/DSIB pad control mux register
from the APB misc block to tegra pinctrl.

Without writing to this register, the dsib pads are
muxed as csi, and cannot be used.

The register is not yet documented in the TRM, here is
the description:

70000820: APB_MISC_GP_MIPI_PAD_CTRL_0
         [31:02] RESERVED
         [01:01] DSIB_MODE       [CSI=0,DSIB=1]
         [00:00] RESERVED


These two patches look good to me.

I think we need to take both patches through the Tegra tree, since if the
Tegra DTs start referencing the new pingroup, the driver must already know
about it or it'll error out. So, I hope for an ack from Linus.

Of course, this only applies if you're sending patches to board .dts files
to use the new feature for 3.18; if not, we can apply the pinctrl driver
through the pinctrl tree instead, and wait until 3.19 to use the new
pingroup. I assume you'll want to use the new feature soon though:-)

I don't have any board .dts patches ready for upstream consumption
quite yet. Feel free to use whichever path to mainline you see fit.

I've actually just sent the Tegra pull requests for 3.18 today. Linus, if you want to take this whole series (or at least patch 1/2) through the pinctrl tree, that would be great. The patches will then already be there when we need them as a basis for any DT patches in the Tegra tree for 3.19.

Patch 2,
Acked-by: Stephen Warren <swarren@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux