On 07/11/2014 08:18 AM, Mikko Perttunen wrote: > Add binding documentation for the nvidia,tegra124-emc device tree > node. > diff --git a/Documentation/devicetree/bindings/memory-controllers/tegra-emc.txt b/Documentation/devicetree/bindings/memory-controllers/tegra-emc.txt > +Required properties : > +- compatible : "nvidia,tegra124-emc". > +- reg : Should contain 1 or 2 entries: > + - EMC register set > + - MC register set : Required only if no node with > + 'compatible = "nvidia,tegra124-mc"' exists. The MC register set > + is first read from the MC node. If it doesn't exist, it is read > + from this property. I echo what Thierry said about the MC register sharing. > +- timings : Should contain 1 entry for each supported clock rate. s/entry/node/ I think. > + Entries should be named "timing@n" where n is a 0-based increasing > + number. The timings must be listed in rate-ascending order. That implies that #address-cells and #size-cells are required too. > +Required properties for timings : ... and a reg property is needed here. > +- clock-frequency : Should contain the memory clock rate. > +- nvidia,parent-clock-frequency : Should contain the rate of the EMC > + clock's parent clock. > +- clocks : Must contain an entry for each entry in clock-names. > + See ../clocks/clock-bindings.txt for details. > +- clock-names : Must include the following entries: > + - emc-parent : EMC's parent clock. Shouldn't clocks/clock-names be part of the main node, not the per-timing node? > +- The following properties contain EMC timing characterization values: > + - nvidia,emc-zcal-cnt-long > + - nvidia,emc-auto-cal-interval > + - nvidia,emc-ctt-term-ctrl > + - nvidia,emc-cfg > + - nvidia,emc-cfg-2 > + - nvidia,emc-sel-dpd-ctrl > + - nvidia,emc-cfg-dig-dll > + - nvidia,emc-bgbias-ctl0 > + - nvidia,emc-auto-cal-config > + - nvidia,emc-auto-cal-config2 > + - nvidia,emc-auto-cal-config3 > + - nvidia,emc-mode-reset > + - nvidia,emc-mode-1 > + - nvidia,emc-mode-2 > + - nvidia,emc-mode-4 > +- nvidia,emc-burst-data : EMC timing characterization data written to > + EMC registers. > +- nvidia,mc-burst-data : EMC timing characterization data written to > + MC registers. > -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html