On Tue, Jul 08, 2014 at 10:47:16AM -0700, Olof Johansson wrote: > On Tue, Jul 8, 2014 at 6:43 AM, Peter De Schrijver > <pdeschrijver@xxxxxxxxxx> wrote: > > On Mon, Jul 07, 2014 at 02:44:17AM +0200, Olof Johansson wrote: > >> On Mon, Jun 23, 2014 at 03:23:45PM -0600, Stephen Warren wrote: > >> > This branch moves code related to the Tegra fuses out of arch/arm and > >> > into a centralized location which could be shared with ARM64. It also > >> > adds support for reading the fuse data through sysfs. > >> > >> The new/moved misc driver isn't acked by any misc maintainer, so I can't > >> take this branch. > >> > >> I saw no indication from searching the mailing list of that either, > >> so it wasn't just a missed acked-by. > >> > >> I wonder if this code should go under drivers/soc/ instead? > > > > It's modelled after sunxi_sid.c which lives in drivers/misc/eeprom/. > > Originally this driver was also in drivers/misc/eeprom/, but Stephen objected > > and therefore it was moved to drivers/misc/fuse. I think that's the right > > place still. > > I disagree, I think this belongs under drivers/soc. Especially since > you're adding dependencies on this misc driver from other parts of the > kernel / other drivers. > > I also don't like seeing init calls form platform code down into > drivers/misc like you're adding here. Can you please look at doing > that as a regular init call setup? > > The fact that you provide data to the rest of the kernel again really > says drivers/soc to me, not drivers/misc. Hi Olof, I just sent a patch series that addresses your comments: [PATCH 00/12] Add NVIDIA Tegra FUSE driver That contains a lot of the cleanup that I've been doing to get things ready for 64-bit. It's essentially what this pull request contained, with a couple of other patches on top to untangle the init sequence so that these can all go into regular init calls. I've tested on all four Tegra generations supported upstream. While there's possibly more that we can do I think it is a reasonable first step and I'd like to get this into 3.17 so that we can start moving out other things after the merge window. It would be great if you could have a look, and if there aren't any objections I'll send out another pull request. Thierry
Attachment:
pgpfwNHyHAr_d.pgp
Description: PGP signature
