Re: [PATCH v3 09/10] ARM: tegra: Rename as3722 node to pmic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/28/2014 09:40 AM, Thierry Reding wrote:
> From: Thierry Reding <treding@xxxxxxxxxx>
> 
> Device tree node name should reflect the kind of device rather than the
> specific name of the device.

> diff --git a/arch/arm/boot/dts/tegra124-venice2.dts b/arch/arm/boot/dts/tegra124-venice2.dts

> -		as3722: as3722@40 {
> +		pmic: pmic@40 {

The patch is fine, so I'll apply it, but note that the naming rule
applies to the node name only, since that's visible in the compiled DTB,
but not the label name, so this could have been left as:

		as3722: pmic@40

That would have avoided the rest of the diffs in this patch, and might
have been useful on a board with a bunch of different PMICs that need to
be differentiated between.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux