Hi Stephan, Thank you for your reply. On Tue, Oct 1, 2013 at 9:19 PM, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote: > On 10/01/2013 08:59 AM, Manish Badarkhe wrote: >> Hi Mark, >> >> Thank you for your reply. >> >> On Tue, Oct 1, 2013 at 2:52 PM, Mark Brown <broonie@xxxxxxxxxx> wrote: >>> On Tue, Oct 01, 2013 at 09:41:04AM +0530, Manish Badarkhe wrote: >>>> This patch changes the driver to avoid the usage of IS_ERR_OR_NULL() >>>> macro. >>> >>> Why? >> >> Code use "IS_ERR_OR_NULL()" properly as per current implementation. But >> as per patches [1], [2] below, the use of "IS_ERR_OR_NULL()" has been >> deprecated. >> Hence done this change. > > The intent was to deprecate to *concept* of checking a return value for > both NULL and an error. Simply removing usage of the macro and replacing > it with the exact same code that was part of the macro doesn't fulfil > the intent at all. Ok, Please drop this patch. Regards Manish Badarkhe -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html