On Wed, Aug 07, 2013 at 06:58:03PM +0200, Stephen Warren wrote:
> On 08/07/2013 05:25 AM, Mark Zhang wrote:
> > From: Peter De Schrijver <pdeschrijver@xxxxxxxxxx>
> >
> > COP is a reset only clock. So this patch adds NO_CLK support
> > then adds the COP clock.
>
> Do we actually need this clock upstream yet?
>
> IIRC, Prashant was working on implementing the common reset API, so I'd
> prefer not to add any reset-only "clocks" to the clock driver, but
> rather to simply make sure that the new reset driver exposes them.
>
It would be better if we can switch to the reset API.
> > diff --git a/drivers/clk/tegra/clk-tegra114.c b/drivers/clk/tegra/clk-tegra114.c
>
> > enum tegra114_clk {
> > - rtc = 4, timer = 5, uarta = 6, sdmmc2 = 9, i2s1 = 11, i2c1 = 12,
> > + cop = 1, rtc = 4, timer = 5, uarta = 6, sdmmc2 = 9, i2s1 = 11, i2c1 = 12,
>
> To make this change, you would also need to edit
> include/dt-bindings/clock/tegra114-car.h. BTW, why doesn't the Tegra
> clock driver include that file rather than defining its own enum?
History. include/dt-bindings/clock/tegra114-car.h didn't exist when
clk-tegra114.c was written.
Cheers,
Peter.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
