On 08/01/2013 01:13 AM, Stephen Warren wrote: > On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: >> Add device tree entries for the 3 USB controllers and PHYs and >> enable the third controller on Cardhu and Beaver boards. >> >> Fix VBUS regulator entries on Beaver. The GPIO pins were wrong. > > That much is correct. > >> Also, a third GPIO is required to power the pullup resistors that drive >> the VBUS voltage switches, so add an regulator entry for that. > > That is not true. GMI_AD13 / PH5 / 61 is a signal that pulls up all of > USB1 VBUS, USB3 VBUS, and GMI_AD15, which as far as I can tell is > entirely unrelated to USB in any way. I sent a v2 that enables the internal pullups on those pins. > This part of the change should be removed. I know you mentioned that > downstream does this, but that means very little; there are many > mistakes there. It looks like the pullup resistor from PH5 to GMI_AD15 was added in a later board revision, so the HW guys are to blame this time. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html