On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: > Add device tree entries for the 3 USB controllers and PHYs and > enable the third controller on Cardhu and Beaver boards. > > Fix VBUS regulator entries on Beaver. The GPIO pins were wrong. That much is correct. > Also, a third GPIO is required to power the pullup resistors that drive > the VBUS voltage switches, so add an regulator entry for that. That is not true. GMI_AD13 / PH5 / 61 is a signal that pulls up all of USB1 VBUS, USB3 VBUS, and GMI_AD15, which as far as I can tell is entirely unrelated to USB in any way. This part of the change should be removed. I know you mentioned that downstream does this, but that means very little; there are many mistakes there. Aside from that, this patch looks fine. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
