Re: [PATCH -next v2] spi: tegra: slink: make local symbols static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 05, 2013 at 09:45:36PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> 
> Neither tegra20_spi_cdata nor tegra30_spi_cdata are used outside this
> file so they can, and should, be static.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> ---
>  drivers/spi/spi-tegra20-slink.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
> index 4e58b53..b224a82 100644
> --- a/drivers/spi/spi-tegra20-slink.c
> +++ b/drivers/spi/spi-tegra20-slink.c
> @@ -1087,11 +1087,11 @@ static struct tegra_spi_platform_data *tegra_slink_parse_dt(
>  	return pdata;
>  }
>  
> -const struct tegra_slink_chip_data tegra30_spi_cdata = {
> +static const struct tegra_slink_chip_data tegra30_spi_cdata = {
>  	.cs_hold_time = true,
>  };
>  
> -const struct tegra_slink_chip_data tegra20_spi_cdata = {
> +static const struct tegra_slink_chip_data tegra20_spi_cdata = {
>  	.cs_hold_time = false,
>  };
>  

Reviewed-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx>

Attachment: pgp5GS6bVMIco.pgp
Description: PGP signature


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux