On Tue, Apr 02, 2013 at 10:40:50PM +0200, Thierry Reding wrote: > The cleanup path checks whether the transceiver was properly initialized > using IS_ERR(). However it can also happen that the cleanup path is run > before the transceiver was initialized (or the operating mode isn't set > to TEGRA_USB_OTG) and is therefore NULL. Add a separate label for error > unwinding and initialize the transceiver field to ERR_PTR(-ENODEV) when > the operating mode isn't TEGRA_USB_OTG to allow for consistent checking. > > Signed-off-by: Thierry Reding <thierry@xxxxxxxx> > Acked-by: Venu Byravarasu <vbyravarasu@xxxxxxxxxx> > Acked-by: Stephen Warren <swarren@xxxxxxxxxx> > --- > drivers/usb/host/ehci-tegra.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) This patch fails to apply to my tree: checking file drivers/usb/host/ehci-tegra.c Hunk #2 succeeded at 765 with fuzz 1. Hunk #3 succeeded at 774 with fuzz 2 (offset 1 line). Hunk #4 FAILED at 796. 1 out of 4 hunks FAILED Can you please fix it up and resend it, keeping the needed acks on it? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
