On 01/15/2013 01:17 AM, Hiroshi Doyu wrote: > Add SMMU entry. > diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi > + smmu { > + compatible = "nvidia,tegra114-smmu", "nvidia,tegra30-smmu"; > + reg = <0x7000f010 0x02c > + 0x7000f1f0 0x010 > + 0x7000f228 0x074>; Oh, so the only change here relative to Tegra30 is that the final memory range is larger; the others don't move around at all. Is that all that patch 4/6 is trying to cope with? If so, I'd suggest simplifying that patch a bunch; perhaps just remove the final if() check in each function and make all accesses with (offs > 0x200) go to smmu->regs[2]? You can always add checks to probe() that memory range 0 and 1 have the expected size such that the code in smmu_{read,write} will work as expected. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html