On Fri, Nov 09, 2012 at 10:34:41AM -0700, Stephen Warren wrote: > On 11/09/2012 06:20 AM, Thierry Reding wrote: > > This set of patches are in preparation for the Tegra DRM driver. They > > add the necessary nodes to the DTSI files and setup the clocks necessary > > for host1x and the display controllers to work properly. The AUXDATA > > table is updated with the entries for the newly added nodes and the PLL > > frequency tables are extended with some frequencies required to make a > > few of the more common LVDS panel and HDMI display modes work. > > > > By default, all output resources (RGB, HDMI, DSI and TVO) are disabled, > > and individual boards need to enable those that they require. > > > > Note that there has been talk to replace the frequency tables by an > > algorithmic computation of the dividers in order to avoid endless > > additions to these tables. No code has surfaced yet, but eventually this > > should replace the static tables. > > This basically looks reasonable. > > I assume the DT bindings are documented in the tegradrm driver series? I > haven't looked at that yet. > > I'd like to see explicit acks for the DT changes from e.g. Terje and > Mark Zhang, and anyone else involved in previous discussions about them. > > Could you please split up the patches a little differently? I'd like to see: > > 1) Changes to the clock driver > 2) Changes to add AUXDATA > 3) Changes to .dts files > > The reason being that these are logically separate changes. (1) and (2) > would be applied to the "soc" branch, and (3) to the "dt" branch. I'll split the patches up some more then. > Finally, I'd prefer not to rename the match parameters in the clock > drivers any more; just set up the AUXDATA to match whatever driver names > the clock driver is expecting. That will reduce churn to the clock > driver. I updated the table mainly because the devices were named very inconsistently. For instance, the output resources and host1x didn't have the tegra- prefix, but the display controllers did. I still think there's enough value in having a consistent set of device names, but this is your tree, so I'll drop those changes and update the AUXDATA table if that's what you want. > I really hope soon that Tegra will support DT bindings for > clocks so we can get rid of the AUXDATA, but unfortunately I haven't > seen any movement towards this:-( Oh yes, please. We wouldn't have any of the above problem if we had proper DT bindings for this. Who needs to be prodded to speed this up? Thierry
Attachment:
pgpGe4FiuJhDr.pgp
Description: PGP signature
