On Fri, Jul 27, 2012 at 02:26:06PM -0600, Stephen Warren wrote:
> On 07/25/2012 09:06 AM, Thierry Reding wrote:
> > The Medcom is a 16:9 15" terminal that is used for patient infotainment
> > in hospitals.
>
> > diff --git a/arch/arm/boot/dts/tegra20-medcom.dts b/arch/arm/boot/dts/tegra20-medcom.dts
>
> > + model = "Avionic Design Medcom-Wide board";
> > + compatible = "ad,medcom-wide", "nvidia,tegra20";
>
> The filename implies just "medcom" but the compatible value says
> "medcom-wide". I assume the two should match. Are there multiple medcom
> versions, with SW-visible differences?
Actually there's about 5 different Medcom versions. Medcom-Wide is the
newest incarnation and is the one using the Tamonten/Tegra20. Older ones
were PXA and VR41xx-based and there are also Atom-based variants. For
the Tegra20-based devices, Medcom-Wide is the actual marketing name. I
know the U-Boot support also currently uses just "medcom". For the
kernel it's probably okay to keep it to just "medcom" because I doubt
there will ever be a second variant using the Tegra20. There is probably
going to be a Tegra30-based variant, but the DTS files will already have
a different prefix anyway. I have no idea what the marketing or model
name will be, so maybe using "medcom-wide" as the compatible value will
be best.
I should probably sit down with marketing and talk about this.
> > + sdhci@c8000600 {
> > + cd-gpios = <&gpio 58 0>; /* gpio PH2 */
> > + wp-gpios = <&gpio 59 0>; /* gpio PH3 */
> > + status = "okay";
> > + };
>
> You want a bus-width property in that node. Same for Plutux.
Okay, will do.
> > + backlight {
> > + compatible = "pwm-backlight";
> > + pwms = <&pwm 0 5000000>;
>
> The tegra20.dtsi doesn't assign label "pwm" to the PWM controller yet...
Yes, that's in a separate patch that I forgot to add to the series.
> The Plutux comments all apply here as well.
Alright. I'll update the patches. I suppose most applies to the TEC as
well. Perhaps it even makes sense to separate commonalities out into a
tegra20-tamonten.dtsi?
Thierry
Attachment:
pgp9kNALP2dnf.pgp
Description: PGP signature
