RE: [PATCH v2] arm/tegra: emc: device tree support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Olof Johansson wrote at Wednesday, January 04, 2012 11:02 PM:
> Add device tree support to the emc driver, filling in the platform data
> based on the DT bindings.
> 
> Changes since v1:
> 
> * Unmangled some messed up patch squashes, moving changes to earlier patches
> * Flipped an of_property_read_u32 return value test
> * Clarified clock settings message on case where no table is provided
> 
> Signed-off-by: Olof Johansson <olof@xxxxxxxxx>
...
> diff --git a/arch/arm/mach-tegra/tegra2_emc.c b/arch/arm/mach-tegra/tegra2_emc.c
...
> +static struct tegra_emc_pdata __devinit *tegra_emc_fill_pdata(struct platform_device *pdev)
...
> +	pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
> +	pdata->tables = devm_kzalloc(&pdev->dev,
> +				     sizeof(struct tegra_emc_table),
> +				     GFP_KERNEL);

You could convert that one to sizeof(*pdata->tables) too, although feel
free to ignore this picky comment, or fix it up when you apply the change.

Otherwise,

Acked-by: Stephen Warren <swarren@xxxxxxxxxx>

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux