On Wed, Jan 04, 2012 at 12:03:30AM +0100, Stephen Warren wrote: > Peter De Schrijver wrote at Monday, January 02, 2012 8:18 AM: > > This patchset introduces the tegra30 clockframework. Clocks which require > > voltage scaling are not included in this version. The implementation doesn't > > use the generic clock code yet. It's the intention to move to it, once the > > semantics are fully clarified. > > I'm not particularly familiar with Tegra's clocks, but nothing really > stood out as wrong with this patch on a quick look-through. It'd be great > if someone like Colin could look this over. > > A couple thoughts below. You've probably thought about some of these > already, but I just wanted to make sure:-) > > * Are we following the common clock stuff so we can move over once it's > ready? > I think we can use the same approach then OMAP4 to convert this to the common clock stuff. > * Are Tegra20 and Tegra30 so different we can't re-use any of the code > in tegra2_clocks.c for Tegra30? > Apart from some small functions (such as clk_measure_input_freq()), it's not easy to share code between both. > * The device names in the peripheral clock table might benefit from a > review to make sure they match tegra2_clocks.c for the drivers we've > actually upstreamed at least. Good point. I should check that... Cheers, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
