Olof Johansson wrote at Wednesday, December 07, 2011 5:11 PM:
> On Wed, Dec 07, 2011 at 03:13:44PM -0700, Stephen Warren wrote:
> > Seaboard and Ventana share some GPIOs, but others are different. Split the
> > GPIO table into common, seaboard-specific, and ventana-specific tables, so
> > that only the correct ones are enabled for each board. Add a few missing
> > audio-related GPIOs for Ventana.
...
> > +static struct tegra_gpio_table ventana_gpio_table[] = {
> > + /* hp_det */
> > + { .gpio = TEGRA_GPIO_PW2, .enable = true },
> > + /* int_mic_en */
> > + { .gpio = TEGRA_GPIO_PX0, .enable = true },
> > + /* ext_mic_en */
> > + { .gpio = TEGRA_GPIO_PX1, .enable = true },
> > +};
>
> These should be given symbolical names instead.
I only gave the Seaboard GPIOs symbolic names because they all ended up
being used in multiple places; in this GPIO table, in platform data,
etc. Given that Ventana is a DT-only board, and this is the only place
that the GPIOs will ever be named by code rather than *.dts files, does
it make sense to require symbolic names? If you do think so, I don't
really have any objection to making names.
--
nvpublic
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
