hi, On Wed, Nov 02, 2011 at 07:21:12PM +0000, Russell King - ARM Linux wrote: > On Wed, Nov 02, 2011 at 12:09:36PM -0700, Stephen Warren wrote: > > To solve this, I recommend definining ARCH_NR_GPIOs for Tegra, to something > > large; I see that arch/arm/mach-shmobile defines it to 1024. Failing any > > disadvantage of using a number that large, I'd go for that... > > I'd suggest that we immediately start solving the ARCH_NR_GPIO > definition a single zImage friendly way - rather than throwing a > definition into mach/gpio.h, add this into asm/gpio.h: > > #if CONFIG_ARCH_NR_GPIO > 0 > #define ARCH_NR_GPIO CONFIG_ARCH_NR_GPIO > #endif > > and in arch/arm/Kconfig: > > config ARCH_NR_GPIO > int > default 1024 if ARCH_SHMOBILE || ARCH_TEGRA > ... etc ... > default 0 > > The list should be sorted in numeric order, largest first. > > This then gives us a path to eliminate the ARCH_NR_GPIO definitions > from mach/gpio.h - and should allow more mach/gpio.h to become empty. would it be better to just change the default value in arm-generic/gpio.h to something very large ? I mean, ideally that wouldn't be gpio_desc wouldn't be an array anyway right ? -- balbi
Attachment:
signature.asc
Description: Digital signature
