Peter De Schrijver wrote by Wednesday, November 02, 2011 9:38 AM: > Tegra30 has 1 extra legacy interrupt controller. Use the GIC ITLinesNumber > field to determine how many interrupt controllers we have and initialize > appropriately. Also make room for the extra tegra30 interrupts by moving > the GPIO IRQ base. This shouldn't affect existing code as it determines the > correct IRQ number for GPIOs using TEGRA_GPIO_TO_IRQ() > > Signed-off-by: Peter De Schrijver <pdeschrijver@xxxxxxxxxx> After fixing one small issue I comment on below, Acked-by: Stephen Warren <swarren@xxxxxxxxxx> I was previously concerned that renumbering the interrupt IDs would cause some kind of backwards compatibility problems, but thinking more, I don't think there's an issue; for a DT-based system, all the IRQ and GPIO numbers are specified relative to the controller, and the relative numbering isn't changing here. For a non-DT-based system, any IRQ numbers for any GPIO should indeed be generated using TEGRA_GPIO_TO_IRQ (or the run-time equivalent) and hence should also work OK after this patch. > diff --git a/arch/arm/mach-tegra/include/mach/irqs.h b/arch/arm/mach-tegra/include/mach/irqs.h ... > #define NR_BOARD_IRQS 32 > - > -#define NR_IRQS (INT_BOARD_BASE + NR_BOARD_IRQS) > -#endif > +#define NR_IRQS (INT_BOARD_BASE + NR_BOARD_IRQS) The indentation change to NR_IRQS seems like a mistake; the existing code looks OK. -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
