On 03/09/11 12:15, Mark Brown wrote: > On Wed, Mar 09, 2011 at 09:41:23AM +0200, Mike Rapoport wrote: >> On 03/08/11 15:15, Mark Brown wrote: > >>> I feel sure that some of these could be using a struct device, though >>> since they're probably all going to be required to be always on I'd >>> expect it's not useful to have them mapped as supplies at all and the >>> drivers could just assume they were there. > >> I'd prefer to keep it as is for now and update the supplies when merging the >> drivers that actually use them. > > There's no point in keepig them if they don't match up with the actual > drivers and having this sort of stuff in the kernel means it might get > picked up as reference code by other users. If you want to label the > supplies to match the rails on the board the name field in constraints > is intended for that purpose. As for me, I'd be fine with registering only the pex_clk supply and ldo0 to allow PCI-e on Harmony :) If Tegra folks are Ok with it, I'd drop the rest and we'll add more regulators and supplies together with drivers that use them. -- Sincerely yours, Mike. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html