On 03/08/11 15:15, Mark Brown wrote: > On Tue, Mar 08, 2011 at 02:58:58PM +0200, Mike Rapoport wrote: > >> +static struct regulator_consumer_supply tps658621_ldo2_supply[] = { >> + REGULATOR_SUPPLY("vdd_rtc", NULL), >> +}; > > I feel sure that some of these could be using a struct device, though > since they're probably all going to be required to be always on I'd > expect it's not useful to have them mapped as supplies at all and the > drivers could just assume they were there. I'd prefer to keep it as is for now and update the supplies when merging the drivers that actually use them. >> +#define REGULATOR_INIT(_id, _minmv, _maxmv) \ >> + { \ > > This should be namespaced, someone might add a generic macro with that > name. Ok, will fix. -- Sincerely yours, Mike. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html