Hi, On Mon, Jan 24, 2011 at 8:53 PM, Varun Wadekar <vwadekar@xxxxxxxxxx> wrote: > ---- > rtc: tps6586x: add RTC driver for TI TPS6586x > > Signed-off-by: Gary King <gking@xxxxxxxxxx> Your patch seems to be line wrapped. There seems to be whitespace damage overall in it. Please don't put dashes in the changelog, git will strip what's below. You also numbered the patches 0/2, 1/2 and 2/2 -- 0/<x> is normally used just for an overall description of the following patches when a series is posted. Since the two follow-on patches are incremental, please squash them into this one before posting -- no need to keep them separate since it's the original submission. Also, you should add your own Signed-off-by if you're posting it. > > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > index 48ca713..241c7f7 100644 > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig > @@ -286,6 +286,13 @@ config RTC_DRV_DM355EVM > help > Supports the RTC firmware in the MSP430 on the DM355 EVM. > > +config RTC_DRV_TPS6586X > + tristate "TI TPS6586X RTC" > + depends on I2C > + select MFD_TPS6586X Shouldn't this be a depend instead of a select? That's how some of the other MFD RTCs seem to do it. > + help > + This driver supports TPS6586X RTC > + > config RTC_DRV_TWL92330 > boolean "TI TWL92330/Menelaus" > depends on MENELAUS -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
