[PATCH 2/2] rtc: tps6586x: fix error in tick calculations.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This patch depends on patch 1:

----
    rtc: tps6586x: fix error in tick calculations.

    when converting from seconds to ticks using a shift
    operator, the most significant bits were being lost
    due to seconds being a 32-bit value and ticks being
    a 64-bit value. a hard cast was added to avoid this
    loss.

    Signed-off-by: Lowell Dennis <ldennis@xxxxxxxxxx>

diff --git a/drivers/rtc/rtc-tps6586x.c b/drivers/rtc/rtc-tps6586x.c
index 9ab93cb..ca6138b 100644
--- a/drivers/rtc/rtc-tps6586x.c
+++ b/drivers/rtc/rtc-tps6586x.c
@@ -95,7 +95,7 @@ static int tps6586x_rtc_set_time(struct device *dev,
struct rtc_time *tm)

     seconds -= rtc->epoch_start;

-    ticks = seconds << 10;
+    ticks = (unsigned long long)seconds << 10;
     buff[0] = (ticks >> 32) & 0xff;
     buff[1] = (ticks >> 24) & 0xff;
     buff[2] = (ticks >> 16) & 0xff;
@@ -148,7 +148,7 @@ static int tps6586x_rtc_set_alarm(struct device
*dev, struct rtc_wkalrm *alrm)
     }

     seconds -= rtc->epoch_start;
-    ticks = (seconds << 10) & 0xffffff;
+    ticks = (unsigned long long)seconds << 10;

     buff[0] = (ticks >> 16) & 0xff;
     buff[1] = (ticks >> 8) & 0xff;

nvpublic
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux