Mike Rapoport wrote on Saturday, January 08, 2011 11:57 PM: > Hi Stephen, > > On 01/05/11 20:13, Stephen Warren wrote: > > From: Stephen Warren <swarren@xxxxxxxxxx> > > > > This patch-set is for for-next. > > > > This basically just adds support for the cdev[12] clocks. However, to make > > the clock init code automatically pick up state from the initial pinmux > > configuration, some new pinmux APIs were required, and as discussed, the > > Harmony pinmux init call needed to be moved. > > I think that the logic here should be the other way around. Instead of using > pinmux settings to determine the cdev clock parent, I'd use .set_parent method > to update the pinmux... Mike, That's exactly what this patch does in the set_parent method. However, when the clock code initializes, it sets the initial clock state based on the pinmux state at that time. This pinmux->clock dataflow is a one-time event. -- Nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html