Hi Stephen, On 01/05/11 20:13, Stephen Warren wrote: > From: Stephen Warren <swarren@xxxxxxxxxx> > > This patch-set is for for-next. > > This basically just adds support for the cdev[12] clocks. However, to make > the clock init code automatically pick up state from the initial pinmux > configuration, some new pinmux APIs were required, and as discussed, the > Harmony pinmux init call needed to be moved. I think that the logic here should be the other way around. Instead of using pinmux settings to determine the cdev clock parent, I'd use .set_parent method to update the pinmux... > The remaining hole, and I'm not sure if it's worth solving, is if someone > uses the pinmux API to change the cdev[12] mux after the clock code has > initialized, the clock code won't notice this. Some kind of pinmux->clock > callback could be set up to solve this, but perhaps it's better to simply > "not do that". > > Stephen Warren (3): > ARM: tegra: pinmux: Expose set_func, add get_* > ARM: tegra: Add clk_dev1/2 to tegra2_clocks.c > ARM: tegra: Harmony: Move pinmux init call > > arch/arm/mach-tegra/board-harmony.c | 4 +- > arch/arm/mach-tegra/include/mach/pinmux.h | 9 ++ > arch/arm/mach-tegra/pinmux.c | 64 +++++++++++++-- > arch/arm/mach-tegra/tegra2_clocks.c | 133 +++++++++++++++++++++++++++++ > 4 files changed, 202 insertions(+), 8 deletions(-) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-tegra" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Sincerely yours, Mike. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
