Re: [PATCH] Modular backends version 3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



You mean you prefer the previous version of the patch always builds
tgtd with modular backends ?

If so, that is fine with me. I just thought there was some pushback on
that approach so I did this patch as a compromise.



On Mon, Aug 26, 2013 at 4:59 PM, Dan Mick <dan.mick@xxxxxxxxxxx> wrote:
> I think this is a bad idea; this will encourage package builders to build a
> version which cannot be updated/new backends supplied, which removes a lot
> of the advantage of building with .so backends to begin with.  Why are we
> abandoning dynamic-by-default?
>
>
> On 08/25/2013 12:12 PM, Ronnie Sahlberg wrote:
>>
>> List, Tomo
>>
>> Please review and/or apply.
>>
>> This is the third version of adding support for modular backing stores.
>>
>> By default TGTD will continue to build as a monolithic binary, like it has
>> always done.
>> The patch moves some code from other parts of TGTD into bs.c to make the
>> modular build possible but apart from moving codend adding a bs_ prefix
>> it should not change anything for the default build.
>>
>> IF TGTD is build with modular support :
>> make MODULAR_BUILD=1
>> then bs.c will be built into a shared library for support functions and
>> the initialization code is changed to automatically try to scan for and
>> load
>> all backing store modules installed.
>> Additionally bs_aio|null|rbd|rdwr|ssc are built as separate shared modules
>> that can be distributed separately from the rest of TGTD.
>>
>>
>> With this patch TGTD will continue to build as a single monolithic binary
>> as
>> always but for users that want to have modular backends the changes allow
>> them
>> to build a modular version.
>>
>>
>> ronnie sahlberg
>>
>
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Linux RAID]     [Linux Clusters]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]

  Powered by Linux