Resending, as the mail sent from gmail bounced. Tomo, could you please enable postings from "nezhinsky@xxxxxxxxx" if that was the problem. Alexander -------- Original Message -------- Subject: Re: [PATCH 0/5 RESEND] mgmt and concat_buf Date: Thu, 16 Feb 2012 15:46:03 +0200 From: Alexander Nezhinsky <nezhinsky@xxxxxxxxx> To: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> CC: <alexandern@xxxxxxxxxxxx>, <stgt@xxxxxxxxxxxxxxx> 2012/2/16 FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx <mailto:fujita.tomonori@xxxxxxxxxxxxx>> On Tue, 14 Feb 2012 17:25:00 +0200 Alexander Nezhinsky <alexandern@xxxxxxxxxxxx <mailto:alexandern@xxxxxxxxxxxx>> wrote: > On 02/12/2012 01:01 AM, FUJITA Tomonori wrote: > > Here it ends. If you look the patch 2/5 that i sent, it is concluded with the > following lines: > +typedef enum tgtadm_errno tgtadm_err; > + > #endif Oops, I can't cleanly apply that patch so I did by hand. >> make sure every patch compilable. > > I don't see any easy way now to produce a fine-grained patch set. > Thus i am going to send you a unified patch with all the changes. Tomo, Perhaps it'd be better to apply the new "big" patch, which is rebased upon the latest master and doesn't break bisectability. The rebase required some non-mechanical fixes to the latest commits, which are mainly centered around device type template's lu_online() and lu_offline(). They returned int but actually it was tgtadm_err, so first of all i updated the ret types. Then tgtadm_err is not a bitmask thus in the following code just assigning "err" is ok: spc.c::spc_lu_online() ... case Opt_online: match_strncpy(buf, &args[0], sizeof(buf)); if (atoi(buf)) err |= lu->dev_type_template.lu_online(lu); else err |= lu->dev_type_template.lu_offline(lu); break; I'm looking forward to see the patch applied to be able to further improve it, and to start sending other stuff. Alexander -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
