Sorry for the late response. On Wed, 1 Feb 2012 15:37:06 +0200 Alexander Nezhinsky <alexandern@xxxxxxxxxxxx> wrote: > This patch series introduces concat_buf mechanism (based on open_memstream) > to dynamically produce response buffers for management tasks in tgtd and > request buffers for management tasks in tgtadm. I got compile errors with this patchset. You can find my tree with this patchset: git://github.com/fujita/tgt.git concat I got something like the following: In file included from iscsi/iscsid.h:30, from iscsi/transport.c:27: ./tgtd.h:119: error: expected specifier-qualifier-list before ‘tgtadm_err’ ./tgtd.h:136: error: expected specifier-qualifier-list before ‘tgtadm_err’ ./tgtd.h:230: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘tgt_device_create’ ./tgtd.h:231: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘tgt_device_destroy’ ./tgtd.h:232: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘tgt_device_update’ ./tgtd.h:236: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘tgt_device_path_update’ ./tgtd.h:238: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘tgt_target_create’ ./tgtd.h:239: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘tgt_target_destroy’ ./tgtd.h:241: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘tgt_target_show_all’ ./tgtd.h:243: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘system_show’ In addition, the first patch doesn't look 'git bisect'able. Please make sure every patch compilable. Thanks, -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html